[libcxxabi] r296940 - Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp

Jonathan Roelofs via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 3 18:22:57 PST 2017



On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:
> Author: ericwf
> Date: Fri Mar  3 19:26:41 2017
> New Revision: 296940
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev
> Log:
> Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp
>
> Modified:
>     libcxxabi/trunk/test/CMakeLists.txt
>     libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp
>     libcxxabi/trunk/test/libcxxabi/test/config.py
>     libcxxabi/trunk/test/lit.site.cfg.in
>
> Modified: libcxxabi/trunk/test/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/CMakeLists.txt?rev=296940&r1=296939&r2=296940&view=diff
> ==============================================================================
> --- libcxxabi/trunk/test/CMakeLists.txt (original)
> +++ libcxxabi/trunk/test/CMakeLists.txt Fri Mar  3 19:26:41 2017
> @@ -18,6 +18,7 @@ pythonize_bool(LIBCXXABI_ENABLE_THREADS)
>  pythonize_bool(LIBCXXABI_ENABLE_EXCEPTIONS)
>  pythonize_bool(LIBCXXABI_USE_LLVM_UNWINDER)
>  pythonize_bool(LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY)
> +pythonize_bool(LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL)

AFAIU, this is only allows specifying it at build time and not 
auto-detection of it. Did you intend on setting this via something like 
a CHECK_CXX_SOURCE_COMPILES check?


Jon


-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded


More information about the cfe-commits mailing list