[PATCH] D30597: [libc++] Attempt to improve diagnostics about Hash requirement violations

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 3 16:54:46 PST 2017


EricWF created this revision.

This is my attempt to improve the diagnostic messages emitted from the unordered containers when the supplied hash doesn't meet the `Hash` requirements.

Unfortunately producing reasonable diagnostics is tricky and it requires a bunch of meta-programming to get right.

@thakis Does this look more reasonable to you?


https://reviews.llvm.org/D30597

Files:
  include/__hash_table
  include/utility
  test/libcxx/containers/unord/unord.set/missing_hash_specialization.fail.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30597.90552.patch
Type: text/x-patch
Size: 7554 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170304/3b2c712d/attachment.bin>


More information about the cfe-commits mailing list