[PATCH] D30569: [clang-tidy] misc-use-after-move: Fix failing assertion

Martin Böhme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 3 05:57:12 PST 2017


mboehme marked an inline comment as done.
mboehme added inline comments.


================
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
   // CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
-  // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+  // CHECK-MESSAGES: [[@LINE-3]]:7: note: move occurred here
 }
----------------
alexfh wrote:
> mboehme wrote:
> > mboehme wrote:
> > > I've seen this column number flapping back and forth between 6 and 7 before.
> > > 
> > > This seems to be unrelated to my fix and instead is triggered simply by adding the extra test case below; even with my fix present, this reverts back to 7 if I remove the test case. Looks like an obscure bug in the way the column number is computed...
> > Should be "reverts back to 6"
> Interesting. Are you sure there's nothing else here in play? Like non-ascii characters or weird line endings?
I just checked -- nothing I can find. The file doesn't contain any bytes with the high bit set, and there aren't any '\r' either.


https://reviews.llvm.org/D30569





More information about the cfe-commits mailing list