[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398
+  case AMDGPU::BI__builtin_amdgcn_ds_permute:
+    return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute);
+  case AMDGPU::BI__builtin_amdgcn_ds_bpermute:
+    return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_bpermute);
+  case AMDGPU::BI__builtin_amdgcn_readfirstlane:
+    return emitUnaryBuiltin(*this, E, Intrinsic::amdgcn_readfirstlane);
+  case AMDGPU::BI__builtin_amdgcn_readlane:
----------------
arsenm wrote:
> Since these don't have mangling, you could add GCCBuiltin to the intrinsic definition and then you wouldn't need these to be handled here
If I remove these, there will be error:

cannot compile this builtin function yet





https://reviews.llvm.org/D30551