[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

[Devin Coughlin via Phabricator via cfe-commits]

dcoughlin added a comment.

Thanks for sticking with this!!

This looks good to me, although I would prefer if the definition of the AnalyzerTest class were moved to the bottom of the lit.cfg file. The other configuration and substitutions are far more important to the rest of clang -- people shouldn't have to scan through analyzer-specific stuff to get to configuration of broad relevance.

I also think you may end up needing to conditionalize setting config.analyzer_format to only occur on non-win32 -- but you can commit and see if it triggers the bots.


https://reviews.llvm.org/D30373