[libcxx] r296822 - Work around GCC linking errors within libc++abi due to missing new/delete definitions

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 13:55:04 PST 2017


Author: ericwf
Date: Thu Mar  2 15:55:03 2017
New Revision: 296822

URL: http://llvm.org/viewvc/llvm-project?rev=296822&view=rev
Log:
Work around GCC linking errors within libc++abi due to missing new/delete definitions

Modified:
    libcxx/trunk/CMakeLists.txt

Modified: libcxx/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=296822&r1=296821&r2=296822&view=diff
==============================================================================
--- libcxx/trunk/CMakeLists.txt (original)
+++ libcxx/trunk/CMakeLists.txt Thu Mar  2 15:55:03 2017
@@ -159,7 +159,12 @@ option(LIBCXX_ENABLE_ABI_LINKER_SCRIPT
 
 set(ENABLE_NEW_DELETE_DEFAULT ON)
 if (LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS)
-  set(ENABLE_NEW_DELETE_DEFAULT OFF)
+# FIXME: This option should default to off. Unfortunatly GCC 4.9 fails to link
+# programs to due undefined references to new/delete in libc++abi so to work
+# around this libc++abi currently defaults LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS
+# to ON. Once the GCC bug has been worked around this option should be changed
+# back to OFF.
+  set(ENABLE_NEW_DELETE_DEFAULT ON)
 endif()
 
 option(LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS




More information about the cfe-commits mailing list