[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers
Devin Coughlin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 2 07:51:31 PST 2017
dcoughlin added a comment.
In https://reviews.llvm.org/D30373#689613, @ddcc wrote:
> With the first method, I'm not sure how to refer to the `AnalyzerTest` class defined in `lit.cfg` from `lit.local.cfg`. It doesn't seem to be in scope, so unless I store an instantiation in the `config` object, I don't think it's accessible.
Rather than creating and storing an instance of AnalyzerTest in lit.cfg you could store the class itself (that is, an instance of the metatype) and then instantiate it using that when needed in lit.local.cfg. This would avoid creating an long-held, global instance of AnalyzerTest when running other tests.
Repository:
rL LLVM
https://reviews.llvm.org/D30373
More information about the cfe-commits
mailing list