[PATCH] D30268: Avoid copy of __atoms when char_type is char

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 21:53:52 PST 2017


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

`__num_get` is externally instantiated.  Adding non-template methods or changing method signatures is ABI breaking (As shown by the `check-cxx-abilist` rule output <https://gist.github.com/EricWF/aeb561d6cd845128b828c41c42de09e8>).

This change needs to be made in a way that maintains ABI compatibility, or it needs to be guarded under a `_LIBCPP_ABI_FOO` macro and only exposed in ABI v2.


https://reviews.llvm.org/D30268





More information about the cfe-commits mailing list