[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 07:48:13 PST 2017


arphaman added inline comments.


================
Comment at: lib/CodeGen/CGBlocks.cpp:1414
+
+} // end anonymous namespace
+
----------------
vsk wrote:
> I don't see the need for two GenericInfo types (although it's plausible it'll make sense with your upcoming changes!). I had in mind a single 'enum BlockCaptureOperationType' with 8 entries, and a 'struct BlockCaptureOperation'.
Agreed, fixed.


Repository:
  rL LLVM

https://reviews.llvm.org/D30345





More information about the cfe-commits mailing list