r296453 - [clang-format] Fix test failure caused by "rm" on some buildbots.
Nico Weber via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 28 05:44:45 PST 2017
It's needed: when clang-format does leave temp files behind, they will
accumulate over builds and even if that's then fixed, the test would still
fail because of the temp files from prior builds. Thankfully, takuni fixed
this better in r296460.
On Feb 28, 2017 4:14 AM, "Haojian Wu via cfe-commits" <
cfe-commits at lists.llvm.org> wrote:
> Author: hokein
> Date: Tue Feb 28 03:03:07 2017
> New Revision: 296453
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296453&view=rev
> Log:
> [clang-format] Fix test failure caused by "rm" on some buildbots.
>
> The begining command "rm" will return 1 when there is not such file to
> delete.
>
> This patch is to remove it, as it's not needed for the test.
>
> Modified:
> cfe/trunk/test/Format/inplace.cpp
>
> Modified: cfe/trunk/test/Format/inplace.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Format/
> inplace.cpp?rev=296453&r1=296452&r2=296453&view=diff
> ============================================================
> ==================
> --- cfe/trunk/test/Format/inplace.cpp (original)
> +++ cfe/trunk/test/Format/inplace.cpp Tue Feb 28 03:03:07 2017
> @@ -1,6 +1,5 @@
> // Regression test to check that clang-format does not leave behind
> temporary
> // files on Windows when doing in-place formatting.
> -// RUN: rm %T/inplace*
> // RUN: cp %s %T/inplace.cpp
> // RUN: clang-format -style=LLVM -i %T/inplace.cpp
> // RUN: ls %T > %T/files.txt
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170228/6383e4be/attachment.html>
More information about the cfe-commits
mailing list