[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

Be best to avoid having to 'fixup' the argabi after the fact - and instead build the type with the right argabi from the get-go.



================
Comment at: lib/CodeGen/CGDebugInfo.cpp:955-957
+    // DWARFv5 doesn't specify explicit DW_CC_* value for this case,
+    // thus we just return 'normal' here.
+    return llvm::dwarf::DW_CC_normal;
----------------
Could you file a bug/feature request with the DWARF committee? & maybe we could/should use an implementation defined extension value here? (assuming the DW_CC set has an implementation defined space - which I really hope it does)


================
Comment at: test/CodeGenCXX/debug-info-type-calling-conventions.cpp:11-12
+
+class UserDtor {
+public:
+  ~UserDtor() {}
----------------
I'd probably make this a struct (and drop the 'public:' section since it'll be the default then) - since it doesn't seem to matter here.


https://reviews.llvm.org/D30378