[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 27 07:10:55 PST 2017

Previous message: [PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded
Next message: [PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

klimek added a comment.

Also, do we want to not call ReplaceFile in Path.inc on Win if it potentially leaves temp files lying around?
Reading the code, it looks like we currently actually believe it may fail, and retry with MoveFileEx afterwards...


https://reviews.llvm.org/D30385

Previous message: [PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded
Next message: [PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list