[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

Jonathan Roelofs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 24 09:45:30 PST 2017


jroelofs added a comment.

In https://reviews.llvm.org/D30339#685919, @rmaprath wrote:

> Perhaps change `config.h` and remove the definition there and adjust other places accordingly?
>
> The current form is very easy to trip over.


Eric's point is that LIBCXXABI_BAREMETAL is a 0/1 flag, not a defined/not-defined flag. Please don't change from one form to the other... it's disruptive to build systems.


Repository:
  rL LLVM

https://reviews.llvm.org/D30339





More information about the cfe-commits mailing list