[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:82
+
+llvm::ErrorOr<std::vector<std::string>> GetWhiteListedSymbolPatterns() {
+  llvm::SmallVector<StringRef, 8> Lines;
----------------
hokein wrote:
> Instead `std::vector<std::string>`, maybe std::vector<llvm::Regex> is better, with that we don't need to do transform stuff in `ChangeNamespaceTool`.
I'd like `ChangeNamespaceTool` to own the Regex vector and make sure it is not shared since Regex is not thread safe. 


https://reviews.llvm.org/D30328