r295843 - [OpenCL] r600 needs OpenCL kernel calling convention

[Hans Wennborg via cfe-commits]

Thanks! r296001.

On Thu, Feb 23, 2017 at 2:01 AM, Anastasia Stulova
<Anastasia.Stulova at arm.com> wrote:
> Sure! No objections here!
>
> Thanks,
> Anastasia
>
> -----Original Message-----
> From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf Of Hans Wennborg
> Sent: 22 February 2017 18:10
> To: Jan Vesely
> Cc: cfe-commits; Matt Arsenault; Anastasia Stulova
> Subject: Re: r295843 - [OpenCL] r600 needs OpenCL kernel calling convention
>
> I'm OK with it if either Matt or Anastasia agrees.
>
> Thanks,
> Hans
>
> On Wed, Feb 22, 2017 at 7:20 AM, Jan Vesely <jan.vesely at rutgers.edu> wrote:
>> Hi Hans,
>>
>> I'd like this commit to make it to 4.0. I'm not sure if it falls under
>> OpenCL or AMDGPU so I've added both Matt and Anastasia to cc.
>>
>> thank you,
>> Jan
>>
>> On Wed, 2017-02-22 at 15:01 +0000, Jan Vesely via cfe-commits wrote:
>>> Author: jvesely
>>> Date: Wed Feb 22 09:01:42 2017
>>> New Revision: 295843
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=295843&view=rev
>>> Log:
>>> [OpenCL] r600 needs OpenCL kernel calling convention
>>>
>>> Differential Revision: https://reviews.llvm.org/D30236
>>>
>>> Modified:
>>>     cfe/trunk/lib/Sema/SemaType.cpp
>>>     cfe/trunk/test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
>>>
>>> Modified: cfe/trunk/lib/Sema/SemaType.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaType.cpp?r
>>> ev=295843&r1=295842&r2=295843&view=diff
>>> =====================================================================
>>> =========
>>> --- cfe/trunk/lib/Sema/SemaType.cpp (original)
>>> +++ cfe/trunk/lib/Sema/SemaType.cpp Wed Feb 22 09:01:42 2017
>>> @@ -3175,7 +3175,7 @@ getCCForDeclaratorChunk(Sema &S, Declara
>>>        if (Attr->getKind() == AttributeList::AT_OpenCLKernel) {
>>>          llvm::Triple::ArchType arch = S.Context.getTargetInfo().getTriple().getArch();
>>>          if (arch == llvm::Triple::spir || arch == llvm::Triple::spir64 ||
>>> -            arch == llvm::Triple::amdgcn) {
>>> +            arch == llvm::Triple::amdgcn || arch ==
>>> + llvm::Triple::r600) {
>>>            CC = CC_OpenCLKernel;
>>>          }
>>>          break;
>>>
>>> Modified: cfe/trunk/test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenOpenCL/amdg
>>> pu-abi-struct-coerce.cl?rev=295843&r1=295842&r2=295843&view=diff
>>> =====================================================================
>>> =========
>>> --- cfe/trunk/test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
>>> (original)
>>> +++ cfe/trunk/test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl Wed Feb
>>> +++ 22 09:01:42 2017
>>> @@ -1,5 +1,6 @@
>>>  // REQUIRES: amdgpu-registered-target  // RUN: %clang_cc1 -triple
>>> amdgcn-unknown-unknown -S -emit-llvm -o - %s | FileCheck %s
>>> +// RUN: %clang_cc1 -triple r600-unknown-unknown -S -emit-llvm -o -
>>> +%s | FileCheck %s
>>>
>>>  // CHECK-NOT: %struct.single_element_struct_arg = type { i32 }
>>> typedef struct single_element_struct_arg
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits