Patch for Bug 30413, including test case

Lobron, David via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 23 06:45:52 PST 2017


Hi Akira,

Pardon my slow reply here- I was traveling and just got back to work email.  I will check into this as soon as I can, and get back to you.

Thank you,

David

> On Feb 20, 2017, at 12:04 AM, Akira Hatanaka <ahatanaka at apple.com> wrote:
> 
> This patch changes the encoding of an id conforming to a protocol, which I think was not intended: For example:
> 
> @encode(id<NSObject>)
> 
> Would passing IVD to the call to getObjCEncodingForType in CGObjCGNU::GenerateClass solve the problem?
> 
>> On Feb 15, 2017, at 1:59 PM, Lobron, David via cfe-commits <cfe-commits at lists.llvm.org> wrote:
>> 
>> Hi All,
>> 
>> I am re-submitting my patch for Bug 30413, this time with a test case included as well (ivar-type-encoding.m).  The test case file should be added to clang/test/CodeGenObjC.  The test verifies that correct metadata is emitted by clang for an object-valued instance variable.  I've verified that the test passes when the patch has been applied to ASTContext.cpp, and fails otherwise.
>> 
>> Please let me know if this looks OK, or if any additional information is needed.
>> 
>> Thanks,
>> 
>> David
>> 
>> <ivar-type-encoding.m><PatchForBug30413.patch>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> 



More information about the cfe-commits mailing list