[PATCH] D30290: [libcxx][zorg] Fix no-exceptions builder configurations

[Renato Golin via Phabricator via cfe-commits]

rengolin added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:1196
+            lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl -L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+            cmake_extra_opts={'LIBCXX_ENABLE_EXCEPTIONS': 'OFF',
+                              'LIBCXXABI_ENABLE_EXCEPTIONS': 'OFF',
----------------
rmaprath wrote:
> rengolin wrote:
> > Why remove the unwinder?
> The unwinder should not be required for the no-exceptions library testing, as these libraries do not throw/catch any exceptions.
> 
> / Asiri
But the requirement is not only to test it, but to make them work. We had trouble making the bot pass without the unwinder, due to dependencies.

Regardless, this is a *different* change and should be made later, with proper research. For now, just add the new flag, please.


https://reviews.llvm.org/D30290