[PATCH] D30131: [profiling] PR31992: Don't skip interesting non-base constructors

[Alex Lorenz via Phabricator via cfe-commits]

arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM.

One point to note, when we are displaying coverage for constructors that have both the base and complete versions instrumented, e.g.:

  class Foo {
  public:
      Foo() { }
  };
  
  class Bar : virtual public Foo {
  public:
     Bar() { }; // llvm-cov will show 2 instantiations for Bar()
  };
  
  class BarBar: public Bar {
  public:
    BarBar() { }
  };
  
  int main (int argc, char* argv[])
  {
      BarBar b;
      Bar bb;
  }

llvm-cov will treat each constructor as an instantiation (like a template instantiation). Should they be treated as instantiations though?


https://reviews.llvm.org/D30131