[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 22 01:40:25 PST 2017
sammccall added a comment.
Thanks for the review, still learning the style :)
================
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:250
+ } else {
+ assert(!"Must match a NamedDecl!");
+ }
----------------
hokein wrote:
> Is the preceding `!` intended?
This does the right thing (!"string" is always false) but generates a warning.
Changed to assert(false && ...)
https://reviews.llvm.org/D30210
More information about the cfe-commits
mailing list