[PATCH] D29221: clang-format-vsix: "format on save" feature

Antonio Maiorano via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 21 21:23:11 PST 2017


amaiorano added inline comments.


================
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:276
+
+            if (Vsix.IsDocumentDirty(document))
+            {
----------------
hans wrote:
> Perhaps return early if `!Vsix.IsDocumentDirty(document)` instead?
Yes, will do.


https://reviews.llvm.org/D29221





More information about the cfe-commits mailing list