[PATCH] D30035: Add const to function parameters

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

Absent I good motivation (i.e, a documented, significant performance change), I don't think we want this - not because it's not a reasonable change (it is!), but because it's an ABI break.

It's unfortunate the `__atoms` were not passed as const in the first place.
An alternate change would be to add a new local variable in these routines:

  const CharT *__cAtoms = __atoms;

and then use `__cAtoms` instead of `__atoms` in the routines.

But we should determine if this is a win, code-gen wise.


https://reviews.llvm.org/D30035