[PATCH] D30191: [clang-tidy] Reword the "code outside header guard" warning.

Benjamin Kramer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 21 03:01:01 PST 2017


bkramer created this revision.
Herald added a subscriber: JDevlieghere.

The check doesn't really know if the code it is warning about came before
or after the header guard, so phrase it more neutral instead of complaining
about code before the header guard. The location for the warning is still
not optimal, but I don't think fixing that is worth the effort, the
preprocessor doesn't give us a better location.


https://reviews.llvm.org/D30191

Files:
  clang-tidy/utils/HeaderGuard.cpp
  unittests/clang-tidy/LLVMModuleTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30191.89182.patch
Type: text/x-patch
Size: 13345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170221/57c1de9b/attachment-0001.bin>


More information about the cfe-commits mailing list