[PATCH] D29419: [Analyzer] Checker for mismatched iterators
Balogh, Ádám via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 20 08:01:47 PST 2017
baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/MismatchedIteratorChecker.cpp:311
+
+void MismatchedIteratorChecker::checkPostStmt(const DeclStmt *DS,
+ CheckerContext &C) const {
----------------
NoQ wrote:
> Hmm. Now i suspect that the `checkBind()` callback should have covered this, both here and in the previous checker. Did you try using that instead, and see if other callbacks are covered by `checkBind()` as well?
You are right. It seems to eliminate the need for checking C++ construct expressions, declarations with initial values and assignments.
https://reviews.llvm.org/D29419
More information about the cfe-commits
mailing list