[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

[Krasimir Georgiev via Phabricator via cfe-commits]

krasimir added inline comments.


================
Comment at: test/Format/check-coding-style-mozilla.cpp:10
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+if (true) {
----------------
sylvestre.ledru wrote:
> krasimir wrote:
> > What is tested here? Brace styles?
> Yes, do you want me to add a comment to explicit that?
I think that after the comments on the non-brace-style features below, it's obvious enough and doesn't need more comments.


================
Comment at: test/Format/check-coding-style-mozilla.cpp:48
+                ,
+                public Y
+{
----------------
sylvestre.ledru wrote:
> krasimir wrote:
> > This does not check precisely what the comment says, because the comment affects the indentation decisions. Better put the comment before the class declaration.
> I know, this is one of the thing I would like to see fixed in clang format or us. 
> I am adding it in the test suite to make sure that we address it
I think this might be better addressed through a bug/feature request, plus an explicit comment here that this is not yet supported, because this is not obvious from just starring at the code.


https://reviews.llvm.org/D30111