[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added inline comments.


================
Comment at: test/Misc/diag-template-diffing.cpp:27
 // CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from 'vector<std::basic_string>' to 'vector<versa_string>' for 1st argument
+// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from 'vector<std::string>' to 'vector<string>' for 1st argument
 // CHECK-NOELIDE-NOTREE: no matching function for call to 'f'
----------------
I think the majority of test changes make sense, we are just adding qualifiers to the typedefs in the diagnostics. I'm curious about this one though, as we are essentially replacing the old diagnostic note `no known conversion from 'vector<std::basic_string>' to 'vector<versa_string>' for 1st argument` by the new note `no known conversion from 'vector<std::string>' to 'vector<string>' for 1st argument`. Is one better than the other? It seems that GCC prefers the former, while ICC the latter. Does it even matter which one we have?


https://reviews.llvm.org/D29944