[PATCH] D30015: Add arch-specific directory to search path

Pirama Arumuga Nainar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 17 09:02:03 PST 2017


pirama added inline comments.


================
Comment at: test/Driver/arch-specific-libdir-rpath.c:18
+//
+// CHECK-ARCHDIR: -L{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux{{.*}} "-rpath" {{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux
+// CHECK-NO-ARCHDIR-NOT: -L{{.*}}Inputs/resource_dir
----------------
Hahnfeld wrote:
> Can you split that into two lines? Then it won't fail if there is some argument added in between
Splitting into two lines makes FileCheck eagerly match the arch-subdir and -rpath into the {{.*}} next to the "-L".  This causes the check for -rpath to fail.

The test accepts intermediate arguments because of the wildcard right after the -L...Inputs/...


https://reviews.llvm.org/D30015





More information about the cfe-commits mailing list