[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

David Majnemer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 16 22:56:28 PST 2017


majnemer added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:2479
+    case Type::DeducedTemplateSpecialization: {
+      QualType DT = dyn_cast<DeducedType>(T)->getDeducedType();
+      assert(!DT.isNull() && "Undeduced types shouldn't reach here.");
----------------
You are unconditionally dereferencing a dyn_cast, this seems bad. Is T sometimes not a DeducedType or should the dyn_cast be a cast?


https://reviews.llvm.org/D30082





More information about the cfe-commits mailing list