[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 16 18:47:31 PST 2017


EricWF added a comment.

I applied `inline` to most of the functions changed in `basic_string`, and updated the ABI lists accordingly.

Please update this patch so it merges with trunk. Note you can add `_LIBCPP_HIDDEN` to the functions in `basic_string` as well if you want, however the `inline`is enough to make them hidden in the dylib.


https://reviews.llvm.org/D29157





More information about the cfe-commits mailing list