[PATCH] D28266: Transparent_union attribute should be possible in front of union (rework)

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 16 09:31:14 PST 2017

Previous message: [PATCH] D27486: Correct class-template deprecation behavior
Next message: [PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

erichkeane added a comment.

Hi guys-
Since this is a rework of Vlad's changes, I'm not sure you noticed that this was a different review!  Anyone have opinions?  Additionally, I had 1 question in SemaDecl.cpp that I think was right, otherwise I hope this is a pretty light review.


https://reviews.llvm.org/D28266

Previous message: [PATCH] D27486: Correct class-template deprecation behavior
Next message: [PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list