[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

Axel Naumann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 16 00:11:12 PST 2017


karies added inline comments.


================
Comment at: lib/Lex/PPDirectives.cpp:1983
+          isLeadingSeparator = false;
+        else
+          Path.append(Component);
----------------
eric_niebler wrote:
> What happens on Windows for an absolute path like "C:/hello/world.h", I wonder? Does this correctly generate the fixit? @karies?
I also cannot reproduce this diag on Windows, likely because NTFS and FAT are case indifferent (not preserving like MacOS) so the file system cannot reply with "this is how *I* would have spelled the file name".


https://reviews.llvm.org/D30000





More information about the cfe-commits mailing list