[PATCH] D30009: Add support for '#pragma clang attribute'

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 15 18:08:40 PST 2017


On 15 February 2017 at 17:45, Hal Finkel via Phabricator via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> hfinkel added a comment.
>
> I don't understand why it only supports some attributes. Is there some
> handling that needs to take place (I don't see anything obvious in this
> patch)? If most attributes will "just work", I'd much rather opt-out the
> few exceptions (which we can then explicitly document), if any, than using
> this opt-in solution.


Only supporting attributes with a GNU spelling also seems a bit strange to
me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170215/0b602409/attachment.html>


More information about the cfe-commits mailing list