[PATCH] D29884: [analyzer] Proper caching in CallDescription objects.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 15 08:36:36 PST 2017
NoQ added inline comments.
================
Comment at: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:73
+ : II(nullptr), IsLookupDone(false), FuncName(FuncName),
+ RequiredArgs(RequiredArgs) {}
----------------
xazax.hun wrote:
> NoQ wrote:
> > Maybe `assert(FuncName.size() > 0)` here?
> Oh, I see now. Yeah, that would make sense :) Do you want me to commit that or will you?
Because C++ checkers are receiving a lot of attention recently, i'd probably be looking into modifying this class to work with qualified names and overloads. You can commit though if you want it sooner :)
Repository:
rL LLVM
https://reviews.llvm.org/D29884
More information about the cfe-commits
mailing list