[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

[Arpith Jacob via Phabricator via cfe-commits]

arpith-jacob marked 8 inline comments as done.
arpith-jacob added a comment.

Alexey, thank you for your review.  I have used SizeTy instead of assuming 64-bits.



================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:725
+                                /*isVarArg=*/false);
+    llvm::Type *InterWarpCopyTypeParams[] = {CGM.VoidPtrTy, CGM.Int32Ty};
+    auto *InterWarpCopyFnTy =
----------------
ABataev wrote:
> You should use `CGM.IntTy` instead of `CGM.Int32Ty` if `(*kmp_InterWarpCopyFctPtr)` really uses `int` type as the second type.
Yes, this should be Int32Ty.  I've modified the function signature in the comment to use int32_t instead of int.


https://reviews.llvm.org/D29879