[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

Mateusz MikuĊ‚a via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 14 05:56:54 PST 2017


mati865 added a comment.

Final decision is left for @rnk and @asl but I'm still against using GCC "internal" headers in the way they aren't supposed to be used. And have MinGW Clang behaving like Linux Clang.

> developer would have to fix the missing headers bug one day

Solving general Clang issue with win32 only fix doesn't seem right.

> he will have to re-fix limits.h the right way and undo this "fix".

It will be better to have proper fix than this hackish workaround in limits.h

> There is a problems with limits.h, fix limits.h. Don't make all headers that happens to be in the same directory as limits.h disappear.

There are more issues hidden unless someone tries to compile specific code (ia32intrin.h for an example, I no longer have example however).


https://reviews.llvm.org/D29464





More information about the cfe-commits mailing list