[PATCH] D24812: Lit C++11 Compatibility Patch #11

[John McCall via Phabricator via cfe-commits]

rjmccall added a reviewer: rnk.
rjmccall added a comment.

Generally looks good to me, thanks.  One question for Reid.



================
Comment at: test/CodeGenCXX/static-init.cpp:14
+// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8
+// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN5test49HasVTableE, i32 0, inrange i32 0, i32 2) }, comdat, align 8
 
----------------
Interesting.  It looks to me like the C++11 IR pattern is actually the only one that would've exposed the bug that Reid was fixing in r242704.  Reid, do you agree?


================
Comment at: test/CodeGenCXX/volatile.cpp:31
     // CHECK:      [[TMP:%.*]] = load i32*, i32** @_ZN5test11xE, align 8
+    // CHECK11:    {{%.*}} = load volatile i32, i32* [[TMP]], align 4
     // CHECK-NEXT: ret void
----------------
CHECK11-NEXT, please.


https://reviews.llvm.org/D24812