[PATCH] D29893: [change-namespace] add an option to dump changed files in YAML.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 13 09:24:22 PST 2017


ioeric added inline comments.


================
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:68
+cl::opt<bool>
+    DumpYAML("dump_yaml",
+         cl::desc("Dump new file content in YAML, if specified."),
----------------
hokein wrote:
> hokein wrote:
> > `dump_result` maybe a clearer name, which also is consistent with clang-move's.
> Nit: Also change the variable name to `DumpResult`.
Since I am also dumping output as plain text, I named this `DumpYAML` for clarity.


https://reviews.llvm.org/D29893





More information about the cfe-commits mailing list