[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

[Eric Christopher via Phabricator via cfe-commits]

echristo added a comment.

In https://reviews.llvm.org/D29770#674961, @sanwou01 wrote:

> Use clang_cc1 -verify for testing as suggested by @rnk.
>
> @echristo, llc does use the same diags interfaces as clang, however, it is
>  lacking the infrastructure to make use of LocCookies.
>
> In any case, I think this test is useful to prevent regressions in inline
>  assembly diagnostics in clang.


The point is that we typically do not want end to end tests (of which this is one) in clang if there's any way to avoid it. In this case we could test the same interfaces by adding support to llc for them (and it would arguably be useful in llc mode anyhow).


https://reviews.llvm.org/D29770