[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

[Etienne Bergeron via Phabricator via cfe-commits]

etienneb added a comment.

Could you add some tests with enums (like the one in your description)?
This is missing and it's a nice to have.



================
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:244
+  // x != 5 || x != 10
+  if (OpcodeLHS == BO_NE || OpcodeLHS == BO_NE)
+    return true;
----------------
The good news is that this code will be catch by this check!
```
  if (OpcodeLHS == BO_NE || OpcodeLHS == BO_NE)   <<-- redundant expression
```
Should be:
```
  if (OpcodeLHS == BO_NE || OpcodeRHS == BO_NE) 
```





https://reviews.llvm.org/D29858