[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

Wojciech Cierpucha via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 13 07:23:26 PST 2017


cierpuchaw added inline comments.


================
Comment at: clangd/DocumentStore.h:42
   /// Delete a document from the store.
-  void removeDocument(StringRef Uri) { Docs.erase(Uri); }
+  void removeDocument(StringRef Uri) { Docs.erase(Uri);
+    for (const auto &Listener : Listeners)
----------------
Shouldn't this be called under a lock_guard?


https://reviews.llvm.org/D29886





More information about the cfe-commits mailing list