[PATCH] D28365: [Driver] Updated for Visual Studio 2017

Hamza Sood via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 13 02:27:29 PST 2017


hamzasood added a comment.

In https://reviews.llvm.org/D28365#665408, @rnk wrote:

> Doesn't your fix mean that the tests will fail on a Windows machine that doesn't have VS because LLVM was built with mingw? Usually in these situations we provide some way to provide a fake toolchain.


I'm not sure. It should be the same behaviour as before, which is that it'll keep going regardless of whether it can find an MSVC instance. Was there some fake toolchain providing that I missed in the old code?


https://reviews.llvm.org/D28365





More information about the cfe-commits mailing list