[PATCH] D29739: Make Lit tests C++11 compatible - Objective-C++

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In https://reviews.llvm.org/D29739#673933, @tigerleapgorge wrote:

> Hi John,
>
> Here is the most recent discussion I can find on cfe-dev.
>  “I'm guessing that Objective-C/C++ is kind of passe, so nobody is really interested in modernizing it”
>  http://lists.llvm.org/pipermail/cfe-dev/2016-December/051844.html
>
> As far as I am aware, there appears to be no strong reason to bump or not to bump ObjC++.


It certainly simplifies the message to say that we've changed the default C++ dialect to C++11 across the board.  That should apply to ObjC++ as well.  I would not describe ObjC++ as passé; it's a very important language for Apple developers.

It is likely that the Rewriter generates C++98-only code.  I believe the Rewriter is no longer being actively maintained; I'm not sure we're ready to propose removing it yet, but if there are specific problems with those tests, I think it makes some sense to just pass -std=gnu++98 for them.

John.


https://reviews.llvm.org/D29739