[PATCH] D29758: [OpenMP] Parallel reduction on the NVPTX device.
Arpith Jacob via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 10 07:49:38 PST 2017
arpith-jacob added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:956-962
virtual void emitReduction(CodeGenFunction &CGF, SourceLocation Loc,
ArrayRef<const Expr *> Privates,
ArrayRef<const Expr *> LHSExprs,
ArrayRef<const Expr *> RHSExprs,
ArrayRef<const Expr *> ReductionOps,
- bool WithNowait, bool SimpleReduction);
+ bool WithNowait, bool SimpleReduction,
+ OpenMPDirectiveKind ReductionKind);
----------------
ABataev wrote:
> Number of parameters is getting too big, maybe it is better to aggregate them into a struct/class?
Thanks Alexey for your comments. I can place 'WithNoWait, SimpleReduction, ReductionKind' in a struct.
Can you explain what 'SimpleReduction' stands for? It isn't create to me when the reduction is simple...
Thanks.
https://reviews.llvm.org/D29758
More information about the cfe-commits
mailing list