[PATCH] D29804: Fully qualify (preprend ::) calls to math functions from libc
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 9 18:43:41 PST 2017
EricWF added a comment.
This LGTM. Although IDK how far we should go to tolerate collisions with imported namespace names, especially since `libc` can't (since they can't add the ::qualifier).
I've wrote tests for this change here <https://gist.github.com/EricWF/a22d7a8ce8031b67bbef81e92b88641b>. However I don't think they can be applied, since libc implementations
may not tolerate them.
https://reviews.llvm.org/D29804
More information about the cfe-commits
mailing list