[PATCH] D29773: Add support for armv7ve flag in clang (PR31358).

Richard Barton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 9 11:50:01 PST 2017


richard.barton.arm accepted this revision.
richard.barton.arm added a comment.
This revision is now accepted and ready to land.

This all LGTM. If I can assume I am allow to approve, then I approve.



================
Comment at: test/Preprocessor/arm-acle-6.4.c:136
+// CHECK-V7VE: __ARM_FEATURE_SIMD32 1
+// CHECK-V7VE: __ARM_FEATURE_UNALIGNED 1
+
----------------
Seems like we could check for __ARM_FEATURE_IDIV here too since we know it must be there.

Oh - I see it is tested in another test, in which case fine. 

I guess these test files are a bit of a mess already.


https://reviews.llvm.org/D29773





More information about the cfe-commits mailing list