[PATCH] D29704: [XRay] [clang] Allow logging the first argument of a function call.

Dean Michael Berris via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 9 00:19:03 PST 2017


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

Just a minor comment -- I suspect you're going to wait until the patch to LLVM lands?



================
Comment at: lib/Sema/SemaDeclAttr.cpp:4407
+
+  // It isn't a parameter index [0;n), it's a count [1;n] - hence the + 1.
+  D->addAttr(::new (S.Context)
----------------
What is "It" referring to here? The argument?


https://reviews.llvm.org/D29704





More information about the cfe-commits mailing list