[PATCH] D16135: Macro Debug Info support in Clang

[Amjad Aboud via Phabricator via cfe-commits]

aaboud added a comment.

> How much does the build directory grow?
>  Is there any noticeable compile time regression?

I build clang in release mode using GCC, then used that build to build clang in debug mode with "-fstandalone-debug" flag, one time with my changes and another time without my changes.

Without my changes
------------------

Clang executable Size: 1,565MB
Build time: 17m57.504s

Withmy changes
--------------

Clang executable Size: 2,043MB
Build time:  17m58.008s

Do, build time is the same, but binary size was increased about 30%.
However, remember that we are emitting macro debug info in dwarf4 format, once we support emitting it in dwarf5 format the size should be reduced significantly.

> I'm not sure it makes sense to motivate this feature with "-fstandalone-debug" flag.

Is "-fmacro-debug" flag sounds good?
Should we extend DebugInfoKind enumeration to support the debug info macro? Or we should add a new option to CodeGenOptions?


https://reviews.llvm.org/D16135