[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 8 01:11:42 PST 2017


klimek added inline comments.


================
Comment at: lib/Format/UnwrappedLineParser.h:121-123
+  // Comments specifies the sequence of comment tokens to analyze. They get
+  // either pushed to the current line or added to the comments before the next
+  // token.
----------------
krasimir wrote:
> klimek wrote:
> > Given this, I'd perhaps call this addSection or addCommentSection or something similar? analyze sounds like it doesn't change the state of the class...
> Maybe distributeCommentsAccordingToAlignment?
I don't think "AccordingToAlignment" needs to be in the name - it's fine that that's in the comment, and it's kind of a detail of what this does.

The important thing at the call site is that this adds comments to the current unwrapped line, right?


https://reviews.llvm.org/D29626





More information about the cfe-commits mailing list