[PATCH] D29622: Add a batch query and replace tool based on AST matchers.

Julian Bangert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 7 18:31:51 PST 2017


jbangert added a comment.

Thank you for the feedback, addressed and reformatted using llvm style.



================
Comment at: clang-query/QueryReplace.h:35-36
+
+  /// \brief Replacement text. %"identifier" will be substituted by the text of
+  /// an identifier.
+  std::string ToTemplate;
----------------
sbenza wrote:
> klimek wrote:
> > This doesn't seem to come up in the test? (and I don't understand what it's trying to tell me :)
> In the other change the identifier was specified with ${identifier}, not %"identifier".
> They should be consistent, no?
I edited the comment for consistency. This indeed has an older syntax. 


https://reviews.llvm.org/D29622





More information about the cfe-commits mailing list