Add warning for c++ member variable shadowing

[Saleem Abdulrasool via cfe-commits]

On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs <jonathan at codesourcery.com>
wrote:

>
>
> On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
>
>> Don't use the cast for the check, use isa.  Although, since you use the
>> value later, it is probably better to write this as:
>>
>>     if (const auto *RD = cast<CXXRecordDecl>(CurContext))
>>       CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD, RD);
>>
>
>
> @compnerd: s/cast/dyn_cast/ or s/cast/dyn_cast_or_null/, right?
>

Only in that it looks weird.  There is an assert that CurContext is a
CXXRecordDecl, so the cast is perfectly fine.


>
> Jon
>
>
> --
> Jon Roelofs
> jonathan at codesourcery.com
> CodeSourcery / Mentor Embedded
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170207/e6f1f403/attachment.html>