[PATCH] D29221: clang-format-vsix: "format on save" feature

[Antonio Maiorano via Phabricator via cfe-commits]

amaiorano added a comment.

In https://reviews.llvm.org/D29221#668867, @klimek wrote:

> +hans
>
> +1 to "format only current document but save all" not making much sense :)


Yes, I've been using this version for a little while now, and it's not useful to have the current document version. I'll remove it, which will simplify the code as well.

I'll wait a bit more for comments from others before uploading a new version.

Thanks!



================
Comment at: tools/clang-format-vs/ClangFormat/TypeConverterUtils.cs:7
+{
+    public sealed class TypeConverterUtils
+    {
----------------
klimek wrote:
> Perhaps name this "TypeConversion" or something - I find "utils" as part of a name to not add anything, and it tends to accumulate cruft :)
Sounds great, will do that.


================
Comment at: tools/clang-format-vs/ClangFormat/VsixUtils.cs:13
+{
+    internal sealed class VsixUtils
+    {
----------------
klimek wrote:
> Same here, just call it Vsix? (context seems clear enough)
Perfect, will also make this change.


https://reviews.llvm.org/D29221